Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone/fake form tweaks #2

Merged
merged 2 commits into from
Jan 26, 2019

Conversation

HebaruSan
Copy link

@HebaruSan HebaruSan commented Jan 25, 2019

I had a lot of UI suggestions for KSP-CKAN#2665, so rather than going through them one by one in comments, here they are in easily mergeable code form.

  • Move the radio buttons into the section headers
  • Enable/disable clone/fake controls based on the radio buttons
  • All fields aligned at right with labels at left
  • Removed pseudo ghost text
  • Replace instance selection button with dropdown (reverse sort by version)
  • Path selection buttons shrunken and placed after their fields
  • Added a Cancel button
  • Renamed OK button to Create
  • Pressing Esc will cancel out of the form
  • Pressing Enter will attempt to proceed
  • Moved those buttons to very bottom by themselves
  • Moved progress bar to left of the buttons
  • Removed the FormCompatibility stuff since it isn't needed
  • Catch all exceptions since leaving the input path blank wasn't showing an error

image

image

image

@DasSkelett
Copy link
Owner

Nice!
Two smaller issues I see on Windows:
The radio buttons are a bit higher than on Linux, so they are not centered with the group box line.
Also the two select buttons are a bit smaller, but that's not that life threatening.

grafik

@HebaruSan
Copy link
Author

Looks like that's about 5px off, so I split the difference so it'll be 2-3px off in different directions on Mono vs Windows (and the Select buttons are slightly larger now):

image

@DasSkelett
Copy link
Owner

Looks good now!
grafik
Thanks a lot!

@DasSkelett DasSkelett merged commit bbdabf9 into DasSkelett:feature/clone-fake-GUI Jan 26, 2019
@HebaruSan HebaruSan deleted the clone-gui branch January 26, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants