Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup MediaPlayerFactory API #1136

Closed
boushley opened this issue Feb 6, 2016 · 0 comments · Fixed by #1138
Closed

Cleanup MediaPlayerFactory API #1136

boushley opened this issue Feb 6, 2016 · 0 comments · Fixed by #1138
Labels
0 - Backlog

Comments

@boushley
Copy link
Member

boushley commented Feb 6, 2016

The className argument to createAll should either be renamed to selector or should not require the . to be on the front of the variable.

We should not require a class attribute if a source with the dash mime-type is provided.

Any other ideas on how we might cleanup this declarative api would be great.

Maybe instead of requiring an onload we could automatically attach to video elements with a source provided with the correct type? Or maybe support a data-dashjs-create attribute that you put on video elements. Then we run our own handler that processes video elements with that attribute.
boushley added a commit to boushley/dash.js that referenced this issue Feb 6, 2016
@boushley
Refactor MediaPlayerFactory to support a cleaner declarative setup.
00ac58a 
This marks significant progress towards Dash-Industry-Forum#1136.
boushley added a commit to boushley/dash.js that referenced this issue Feb 6, 2016
@boushley
Rename MediaPlayerFactory.js to DeclarativeSetupFactory.
d62928f 
Also update samples that used MediaPlayerFactory.
This should resolve Dash-Industry-Forum#1136 and replace Dash-Industry-Forum#1135
@boushley boushley mentioned this issue Feb 6, 2016
Merged
boushley added a commit to boushley/dash.js that referenced this issue Feb 6, 2016
@boushley
Refactor MediaPlayerFactory to support a cleaner declarative setup.
cee121f 
This marks significant progress towards Dash-Industry-Forum#1136.
boushley added a commit to boushley/dash.js that referenced this issue Feb 6, 2016
@boushley
Update samples that used MediaPlayerFactory.
99930ba 
This should resolve Dash-Industry-Forum#1136 and replace Dash-Industry-Forum#1135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup MediaPlayerFactory simplifying declarative setup boushley/dash.js
1 participant
@boushley