Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong Typescript definition of updateSource #4223

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix wrong Typescript definition of updateSource #4223

merged 2 commits into from
Jul 12, 2023

Conversation

dsilhavy
Copy link
Collaborator

Fixes #4222

@dsilhavy dsilhavy added this to the 4.7.2 milestone Jul 12, 2023
@vodlogic
Copy link
Contributor

Might be worth updating the title of the PR and commit, as the move of the method updateSource(), not getSource()

@dsilhavy dsilhavy changed the title Fix wrong Typescript definition of getSource Fix wrong Typescript definition of updateSource Jul 12, 2023
@vodlogic
Copy link
Contributor

Might be worth updating the title of the PR and commit, as the move of the method updateSource(), not getSource()

I think the commit message still shows getSource...

@dsilhavy
Copy link
Collaborator Author

Might be worth updating the title of the PR and commit, as the move of the method updateSource(), not getSource()

I think the commit message still shows getSource...

I will squash it anyways before merging and change the message then

@dsilhavy dsilhavy merged commit 520cfe5 into development Jul 12, 2023
@dsilhavy dsilhavy deleted the fix/#4222 branch July 14, 2023 07:27
This was referenced Aug 28, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.

TypeScript updateSource() wrongly exported
2 participants
@dsilhavy @vodlogic