Add text.imsc settings for rollUp and displayForcedOnly #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodlogic
suggested changes
Dec 19, 2023
There was a problem hiding this comment.
Please can you also add these new settings to the MediaPlayerSettingsClass interface defined in index.d.ts?
https://github.com/Dash-Industry-Forum/dash.js/blob/development/index.d.ts#L1029
Also change `displayForcedOnly` to `displayForcedOnlyMode` throughout, so it's consistent, because that was a vector for hard-to-spot coding errors.
dsilhavy
requested changes
Jan 10, 2024
eirikbjornr
pushed a commit
to bbc/dash.js
that referenced
this pull request
Feb 14, 2024
…y-Forum#4336) * Add text.imsc settings for rollUp and displayForcedOnly * Add settings to index.d.ts Also change `displayForcedOnly` to `displayForcedOnlyMode` throughout, so it's consistent, because that was a vector for hard-to-spot coding errors. * Address feedback - remove unnecessary player settings
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4332 by allowing imscJS's
displayForcedOnlyModeandenableRollUpparameters to be configured insettings.streaming.text.imsc.displayForcedOnlyModeandsettings.streaming.text.imsc.enableRollUp. Adds configuration check-boxes to the reference player to allow them to be adjusted at playback time.