Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txesbmantool #126

Merged
merged 10 commits into from
Jun 12, 2024
Merged

txesbmantool #126

merged 10 commits into from
Jun 12, 2024

Conversation

PLangowski
Copy link
Collaborator

No description provided.

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
@PLangowski PLangowski changed the title WIP: txesbmantool txesbmantool Jun 5, 2024
@PLangowski PLangowski requested a review from macpijan June 5, 2024 08:04
@PLangowski
Copy link
Collaborator Author

PLangowski commented Jun 5, 2024

@macpijan I'd like to add a cukinia test here, but the tool always returns a non-zero exit code if no actual operation is performed. This would require providing a sample firmware binary to the platform, which is problematic. There is no --help or --version option.
I guess I can test whether the tool exists (using which), but that's about it.

…ol check

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
@PLangowski
Copy link
Collaborator Author

PLangowski commented Jun 5, 2024

I added a test that checks for the tool's existence d59dce4

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
…r file

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
…ol test

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
@macpijan
Copy link
Contributor

There is no --help or --version option.

You can also leave this feedback in the PR adding this tool. At least having help option would be nice.

…fix style

Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
@PLangowski PLangowski requested a review from macpijan June 11, 2024 07:01
PLangowski and others added 2 commits June 11, 2024 09:10
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
@macpijan macpijan merged commit 1a3f975 into develop Jun 12, 2024
@macpijan macpijan deleted the txesbmantool branch June 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants