pre-commit

[PLangowski]

No description provided.

[PLangowski]

@DaniilKl @macpijan I added the fix flag so that oelint fixes some of the files (doesn't work on all checks).
I also added a custom rule that will check for multiline variable assignment and require a 4-space indent to be present. 3b03cfe This, however, does not work yet. I will try to work this out.

[PLangowski]

I'm getting the following error

Can't load rule .oelint-rules.assignment_indent_rule -> the 'package' argument is required to perform a relative import for '.oelint-rules.assignment_indent_rule'

[PLangowski]

The rule file could not be loaded because it was in a hidden directory and Python couldn't find it.

[PLangowski]

@macpijan I got my custom rule to work. It turns out that some of the existing recipes comply to the original oelint rule - They indent to the " character in the first line:

SRC_URI = "git://github.com/nix-community/acpi_call.git;branch=master;protocol=https \
           file://0001-Makefile-fixing-build-errrors.patch \
           file://0001-GPLv3-licence-file-added.patch \
           "

We need to decide what we want: Always a 4 space indent or indenting up to "? What do you think?

[macpijan]

We need to decide what we want: Always a 4 space indent or indenting up to "? What do you think?

Which rule is that? This one as linked in the logs here: #129 (comment)

Can it be autofixed by the tool?

I have been using so far the 4 spaces, but there may be some reason why the upstream linter tool uses the other approach.

It was enough for 3mins search to find this: https://docs.yoctoproject.org/dev/contributor-guide/recipe-style-guide.html#variable-formatting

This should close the discussion and our preference does not matter much. We want to keep the style as in the upstream recipes, to have easier time of upstreaming them and keep the good practices as suggested by the project.

[PLangowski]

Unfortunately, a lot of the rules, including the indent, do not have an autofix and need to be changed manually

[PLangowski]

@macpijan I managed to create an autofix for the indent check. I seems to work except for one case: When the first line of the variable alrerady has something other than "\, e.g.:

SRC_URI = "file://some-file \
<other files>

I haven't managed to get the metod to fix that.

[macpijan]

Sounds like a good start @PLangowski , nice work.

[macpijan]

One more: let's try to cleanup commits.

[PLangowski]

I cleaned up the commits

[DaniilKl]

@PLangowski, ping me please when review will be needed and use draft for a PR next time to signal when the PR is not ready for review.

[PLangowski]

@DaniilKl it is ready for review now.

[macpijan]

Good work overall @PLangowski I have very high hopes on overall quality increase because of these changes.