Cog memory leaks #421
Cog memory leaks #421
Conversation
PLangowski
force-pushed
the
cog-memleaks
branch
3 times, most recently
from
5073f96
to
54744e8
Compare
PLangowski
force-pushed
the
cog-memleaks
branch
3 times, most recently
from
da7cb2c
to
076a356
Compare
PLangowski
force-pushed
the
cog-memleaks
branch
2 times, most recently
from
36bb8a9
to
39fcce8
Compare
PLangowski
force-pushed
the
cog-memleaks
branch
from
39fcce8
to
b9a0915
Compare
assessment/cog-memory-leaks.robot
Outdated
| # Before the tests are executed the platform must be booted into Linux and have | ||
| # Weston running in the background. The user should be logged in as root. |
There was a problem hiding this comment.
@PLangowski, does the required state is achieved using one of the keywords? If not, this can be implemented as a "user input pause", introducing chosen keyword from Dialog library: https://robotframework.org/robotframework/latest/libraries/Dialogs.html#library-documentation-top
There was a problem hiding this comment.
Note that some Python binaries don't have support for tkinter, which is used here. In that case tkinter needs to be installed using a package manager. I tested it with homebrew, not sure about other managers.
We should probably say something about this in the README.
There was a problem hiding this comment.
@PLangowski, why should we rely on manual steps if we can easily automate all steps/commands used within Pause Execution keywords? Some are even ready to use, like booting and logging to Linux. Use our keywords database, where you can use search-bar for your convenience: https://dasharo.github.io/open-source-firmware-validation/
There was a problem hiding this comment.
Booting to Linux requires Dasharo fw and logging in requires a password for the user, which is not the case on my DUT. I was, however, able to automate the other steps. e4bbd9c
There was a problem hiding this comment.
@PLangowski I have added an issue to get back to that in the future: #516
Could you run the test and confirm whether the code with recent changes runs without errors?
There was a problem hiding this comment.
@PLangowski about tkinter and README: https://github.com/Dasharo/open-source-firmware-validation/blame/develop/README.md#L136
There was a problem hiding this comment.
@artur-rs I have tested it and it works
PLangowski
force-pushed
the
cog-memleaks
branch
from
b6b2f20
to
ac48e1c
Compare
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
… steps Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
PLangowski
force-pushed
the
cog-memleaks
branch
from
8b0a8d3
to
f91a5f0
Compare
No description provided.