Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash dts rework 2 #484

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dasharo-compatibility/dasharo-tools-suite.robot
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ DTS005.001 Flash device from DTS shell by using flashrom works correctly
Skip If not ${TESTS_IN_FIRMWARE_SUPPORT} DTS006.001 not supported
Skip If not ${DTS_FIRMWARE_FLASHING_SUPPORT} DTS006.001 not supported
Power On
Disable Firmware Flashing Prevention Options
Boot Dasharo Tools Suite iPXE
Enter Shell In DTS
Set DUT Response Timeout 320s
Flash Firmware In DTS
Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK}
Flash Via Internal Programmer /tmp/coreboot.rom
Power On
Make Sure That Network Boot Is Enabled
Boot Dasharo Tools Suite iPXE
Expand Down
7 changes: 4 additions & 3 deletions dasharo-compatibility/ec-and-super-IO.robot
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ ECR022.001 EC sync update with power adapter connected works correctly
Boot Dasharo Tools Suite iPXE
Enter Shell In DTS
Set DUT Response Timeout 320s
Flash Firmware In DTS ${FW_NO_EC_SYNC_DOWNLOAD_LINK}
Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK}
Flash Via Internal Programmer /tmp/coreboot.rom
Flash EC Firmware
... ${EC_NO_SYNC_DOWNLOAD_LINK} TOOL=dasharo_ectool
Sleep 15s
Expand All @@ -300,7 +301,6 @@ ECR022.001 EC sync update with power adapter connected works correctly
Check Firmware Version ${FW_NO_EC_SYNC_VERSION}
Check EC Firmware Version
... EXPECTED_VERSION=${EC_NO_SYNC_VERSION} TOOL=dasharo_ectool

# Flash new fw with ec sync
Put File ${FW_FILE} /tmp/coreboot_with_ec.rom scp=ALL
${flash_result}= Execute Command In Terminal
Expand Down Expand Up @@ -339,7 +339,8 @@ ECR023.001 EC sync doesn't update with power adapter disconnected
Boot Dasharo Tools Suite iPXE
Enter Shell In DTS
Set DUT Response Timeout 320s
Flash Firmware In DTS ${FW_NO_EC_SYNC_DOWNLOAD_LINK}
Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK}
Flash Via Internal Programmer /tmp/coreboot.rom
Flash EC Firmware
... ${EC_NO_SYNC_DOWNLOAD_LINK} TOOL=dasharo_ectool
Sleep 15s
Expand Down
2 changes: 1 addition & 1 deletion lib/flash.robot
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Flash Via Internal Programmer
END

# If no region is given, flash the whole binary
IF ${region}
IF "${region}" != "${EMPTY}"
${args}= Set Variable -N --ifd -i ${region}
ELSE
${args}= Set Variable ${EMPTY}
Expand Down
Loading