Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capsule-update.robot: Persistence of User Data in Capsule Updates #501

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

JanPrusinowski
Copy link
Contributor

No description provided.

@JanPrusinowski JanPrusinowski changed the title capsule-update.robot: Added UUID and Serial tests capsule-update.robot: Persistence of User Data in Capsule Updates Sep 13, 2024
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
@JanPrusinowski
Copy link
Contributor Author

After fixes at: 96ed8ab : log.zip

dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
dasharo-stability/capsule-update.robot Outdated Show resolved Hide resolved
@krystian-hebel
Copy link
Contributor

I've added few commits to deal with pre-commit and make it launch with QEMU. There are still some issues to resolve, not necessarily here and now:

  • no "flashing", which causes some tests to not actually check anything
    • not sure is it is safe to copy FW file over while QEMU is running and then reset the machine
  • unexpected passes
    • serial number - not actually changed for non-MSI, so default 123456789 is used
    • UUID (Should Be Equal 'Not Settable' 'Not Settable'), similar to above, both could be modified with dcu
    • logo isn't changed, yet the test passes, perhaps it should be skipped for QEMU until flashing works

@SergiiDmytruk SergiiDmytruk mentioned this pull request Oct 2, 2024
@krystian-hebel krystian-hebel force-pushed the Preserve_user_data_during_firmware_updates branch 4 times, most recently from c841492 to 45dc060 Compare October 2, 2024 17:33
@krystian-hebel
Copy link
Contributor

I've rebased and squashed smaller commits were possible. Some of them still have changes to multiple unrelated parts. I think the PR can be merged in this form, I'll just run it one more time to make sure nothing broke during rebase.

Created two issues for problems mentioned in previous comment: #522 and #523.

Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
JanPrusinowski and others added 15 commits October 4, 2024 17:53
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Signed-off-by: Jan Prusinowski <jan.prusinowski@3mdeb.com>
Robotidy always treats first argument to 'Set Suite Variable' keyword
as a global variable. In our case, a local variable specifying name
of a global one is used.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
This file has the version changed only in metadata, but it still
reports whatever CONFIG_LOCALVERSION was set to. As such, it doesn't
make CAP150 pass unless the firmware was acutally updated.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
…e of files

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
@krystian-hebel krystian-hebel force-pushed the Preserve_user_data_during_firmware_updates branch from 6a640f3 to 4d029c7 Compare October 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants