Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the read-only button has a lower zindex value #67

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: the read-only button has a lower zindex value #67

wants to merge 2 commits into from

Conversation

knoxnoe
Copy link

@knoxnoe knoxnoe commented Sep 23, 2022

Snipaste_2022-09-23_08-37-55

greentfrapp
greentfrapp requested changes Oct 7, 2022
View reviewed changes
src/components/Main.vue Outdated
@@ -1,5 +1,5 @@
<template>
<div class="fixed bottom-4 right-4 bg-neutral-800 font-sans text-white px-4 rounded-lg py-2">
<div class="fixed bottom-4 right-4 bg-neutral-800 font-sans text-white px-4 rounded-lg py-2 z-999">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use z-[99] here instead? That way we don't need to change the tailwind config file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we can revert the changes to the tailwind config file

@greentfrapp
Copy link
Contributor

Hey @yrytiannuo sorry for the late reply! Just took a look at the code and requested some changes (see above!) Thanks for spotting this bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greentfrapp greentfrapp greentfrapp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knoxnoe @greentfrapp @yrytiannuo