-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to fetch login or email #216
Conversation
Hello, Thanks for taking the time to open a PR here. I like the idea but I think Let me know what you think about this. |
My pleasure, thanks so much for this awesome tool that saves me so much time every day. Initially, I was going with "username", but then realised that what I wanted to fetch is the login. So if you are okay with "user" we could also use this? Of course, sub-options of password would also be possible and produce less duplicate code. Your call, really 🙂 |
Alright, I'd go for the sub-option then, when I initially made the different commands I followed the content-types that we have in the vault : passwords, secure notes, secrets. |
de7d6b9
to
a8b5894
Compare
Alright, I added the sub-options discussed and also introduced an option to to fetch the email. Any other bits of the credentials worth fetching via the cli? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a naming recommendation and we can go with this, thanks!
@Mikescops done, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works well.
This PR adds a little option to lookup the login for a credential, similar to the password-option.