Add k8s resources types #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
reviewed
Dec 2, 2022
There was a problem hiding this comment.
You will either need to:
- change your local go env to 1.18 and run rake
- wait/approve my codegen fix: [rake] add gimme for default task #201 and re-run
10 tasks
|
Nitpick but the indentation seems off. Also is there any reason they're all in caps? |
JLineaweaver
approved these changes
Dec 20, 2022
xlucas
reviewed
Jan 4, 2023
proto/process/agent.proto
Outdated
Comment on lines
861
to
882
| unsetNodeType = 0; | ||
| pod = 1; | ||
| replicaSet = 2; | ||
| service = 3; | ||
| node = 4; | ||
| cluster = 5; | ||
| job = 6; | ||
| cronJob = 7; | ||
| daemonSet = 8; | ||
| statefulSet = 9; | ||
| persistentVolume = 10; | ||
| persistentVolumeClaim = 11; | ||
| role = 12; | ||
| roleBinding = 13; | ||
| clusterRole = 14; | ||
| clusterRoleBinding = 15; | ||
| serviceAccount = 16; | ||
| ingress = 17; | ||
| deployment = 18; | ||
| namespace = 19; | ||
| crd = 20; | ||
| cr = 21; |
There was a problem hiding this comment.
several thoughts:
- it would make more sense to use the singular for that enum name i.e.
K8sResource - we should use upper case format for values here as specified in https://developers.google.com/protocol-buffers/docs/style#enums
- by convention the first value should have an
UNSPECIFIEDprefix like inK8S_RESOURCE_UNSPECIFIED, is it possible to rename this or is it annoying? unfortunately looks like we started using "unset" here and there for some reason 😕
There was a problem hiding this comment.
Thanks for the feedback, I addressed in c440357
I don't add prefix in proto, such as K8SRESOURCE_POD, because in generated file we can have K8sResource_K8SRESOURCE_POD making me feel the name is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add k8s resources type so it can be used by both agent and backend side
Agent PR DataDog/datadog-agent#14557