SBOM: add support for CycloneDX v1.5 and add HOST_IMAGE SBOMSourceType #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinroh
force-pushed
the
jinroh/sbom-host-image
branch
from
8981c32 to
2a40370
Compare
jinroh
force-pushed
the
jinroh/sbom-host-image
branch
from
2a40370 to
64af5f2
Compare
Bit-Doctor
approved these changes
Feb 7, 2024
aleloup-dd
approved these changes
Feb 7, 2024
AliDatadog
reviewed
Feb 7, 2024
L3n41c
reviewed
Feb 7, 2024
| @@ -29,7 +30,8 @@ message SBOMEntity { | |||
| string hash = 9; // Hash of the SBOM | |||
| oneof sbom { | |||
| cyclonedx.v1_4.Bom cyclonedx = 10; // only cyclonedx will be supported initially but putting it optional will allow us to move to another format later | |||
There was a problem hiding this comment.
I’m wondering if it would make sense to rename that field cyclonedx_1_4 for homogeneity with the new field.
Suggested change
| cyclonedx.v1_4.Bom cyclonedx = 10; // only cyclonedx will be supported initially but putting it optional will allow us to move to another format later | |
| cyclonedx.v1_4.Bom cyclonedx_1_4 = 10; // only cyclonedx will be supported initially but putting it optional will allow us to move to another format later |
It would be a non source compatible change that will require to update:
when bumping the version of agent-payload in those repositories.
But as long as the ID (10) remains unchanged, it has no impact on the on-wire message.
There was a problem hiding this comment.
Agreed. Can we plan that in another PR ?
There was a problem hiding this comment.
Or we can re-open two separate PRs. One for HOST_IMAGE and one for clyclonedx 1.5.x. That'll make things easier for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two changes in
sbom.proto:HOST_IMAGEsource typeMotivation
cc @Bit-Doctor
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.