Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] v6-beta #2883

Draft
wants to merge 165 commits into
base: main
Choose a base branch
from
Draft

[WIP] v6-beta #2883

wants to merge 165 commits into from

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Jul 22, 2024

Caution

Before merging, do not forget to re-enable commented out ci jobs:

  • unit-bs
  • e2e-bs
  • check-staging-merge

Motivation

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 91.02564% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93.49%. Comparing base (c951eec) to head (6d874b7).

Current head 6d874b7 differs from pull request most recent head 387a5ee

Please upload reports for the commit 387a5ee to get more accurate results.

Files with missing lines Patch % Lines
packages/core/src/boot/init.ts 33.33% 2 Missing ⚠️
...src/domain/configuration/transportConfiguration.ts 50.00% 2 Missing ⚠️
packages/logs/src/boot/logsPublicApi.ts 33.33% 2 Missing ⚠️
packages/rum-core/src/boot/rumPublicApi.ts 33.33% 2 Missing ⚠️
packages/rum-core/src/browser/performanceUtils.ts 0.00% 2 Missing ⚠️
...s/rum-core/test/emulate/mockPerformanceObserver.ts 90.47% 2 Missing ⚠️
packages/rum-core/src/browser/cookieObservable.ts 50.00% 1 Missing ⚠️
...kages/rum/src/domain/record/trackers/trackInput.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   93.65%   93.49%   -0.17%     
==========================================
  Files         276      275       -1     
  Lines        7615     7392     -223     
  Branches     1708     1674      -34     
==========================================
- Hits         7132     6911     -221     
+ Misses        483      481       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Jul 22, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.52 KiB 151.50 KiB -10253 B -6.20%
Logs 55.77 KiB 50.68 KiB -5219 B -9.14%
Rum Slim 110.36 KiB 101.71 KiB -8859 B -7.84%
Worker 25.21 KiB 25.16 KiB -47 B -0.18%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.038 0.048 0.010
addtiming 0.001 0.001 0.000
adderror 0.034 0.037 0.003
startstopsessionreplayrecording 0.902 0.833 -0.069
startview 0.986 1.095 0.109
logmessage 0.020 0.021 0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 6.75 KiB 8.21 KiB 1.45 KiB
addaction 38.88 KiB 39.97 KiB 1.09 KiB
addtiming 5.85 KiB 7.78 KiB 1.93 KiB
adderror 42.85 KiB 43.68 KiB 847 B
startstopsessionreplayrecording 5.70 KiB 4.98 KiB -731 B
startview 424.00 KiB 403.32 KiB -21173 B
logmessage 40.75 KiB 38.42 KiB -2381 B

🔗 RealWorld

@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit 612c73e5bd will soon be integrated into staging-30.

Use /to-staging -c to cancel this operation!

dd-devflow bot added a commit that referenced this pull request Jul 25, 2024
@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit 612c73e5bd into staging-30!

You can use this resolution PR: #2893 to fix the conflicts.

If you need support, contact us on Slack #devflow with those details!

@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit 612c73e5bd will soon be integrated into staging-30.

@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration

Commit 612c73e5bd has been merged into staging-30 in merge commit a6a057e8da.

Check out the triggered pipeline on Gitlab 🦊

@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit a6fc9ff046 will soon be integrated into staging-30.

Use /to-staging -c to cancel this operation!

dd-devflow bot added a commit that referenced this pull request Jul 26, 2024
@dd-devflow
Copy link

dd-devflow bot commented Jul 26, 2024

🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit a6fc9ff046 into staging-30!

You can use this resolution PR: #2896 to fix the conflicts.

If you need support, contact us on Slack #devflow with those details!

@dd-devflow
Copy link

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit a6fc9ff046 will soon be integrated into staging-30.

@dd-devflow
Copy link

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration

Commit a6fc9ff046 has been merged into staging-30 in merge commit ab08076032.

Check out the triggered pipeline on Gitlab 🦊

},
public entryTypes: string[] = []

constructor(public callback: PerformanceObserverCallback) {}
Copy link

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 bot Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Quality Violation

Avoid useless constructors (...read more)

This rule is designed to flag constructors that either do nothing or only call the super function. These constructors are unnecessary and can be safely removed. In JavaScript, if a class extends another class and does not have a constructor, it automatically calls the super function with all the arguments it receives.

Unnecessary constructors can lead to confusion for other developers who may be reading or maintaining your code. They might spend time trying to figure out why a constructor is there when it doesn't need to be, or they might assume that the constructor is doing something important when it's not. To follow this rule and write good, clean code, you should only write a constructor if it's doing something other than just calling super.

View in Datadog  Leave us feedback  Documentation

const child = document.createElement('span')
parentWithoutShadowRoot.appendChild(child)

const parameters: Array<[string, Node, Node | null]> = [
Copy link

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 bot Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Array type using 'Array<[string, Node, Node | null]>' is forbidden. Use '[string, Node, Node | null][]' instead. (...read more)

Chose between: T[] and Array<T>. These types are equivalent and it should be consistent across the code base.

View in Datadog  Leave us feedback  Documentation

dd-devflow bot and others added 25 commits October 31, 2024 16:44
…sts (#3057)

* 👷‍♀️ Remove split Chunk false for webpack

* 👷‍♀️ only remove splitChunk with scope  command

* Remove splitchunk by default locally

* remove `splitChunks` everywhere

Somehow, even if we exclude `developer-extension` sources in
browser-stack karma configuration, they still end up in the bundle. In
those sources, we used a Regexp syntax unsupported in older browsers.

This commit work around this issue by using the `new RegExp` constructor
instead of the regexp syntax.

---------

Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants