-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v6-beta #2883
base: main
Are you sure you want to change the base?
[WIP] v6-beta #2883
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
- Coverage 93.65% 93.49% -0.17%
==========================================
Files 276 275 -1
Lines 7615 7392 -223
Branches 1708 1674 -34
==========================================
- Hits 7132 6911 -221
+ Misses 483 481 -2 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 12m Commit 612c73e5bd will soon be integrated into staging-30. Use |
🚨 Branch Integration: This merge request has conflicts We couldn't automatically merge the commit 612c73e5bd into staging-30! You can use this resolution PR: #2893 to fix the conflicts. If you need support, contact us on Slack #devflow with those details! |
🚂 Branch Integration: starting soon, median merge time is 12m Commit 612c73e5bd will soon be integrated into staging-30. |
🚂 Branch Integration Commit 612c73e5bd has been merged into staging-30 in merge commit a6a057e8da. Check out the triggered pipeline on Gitlab 🦊 |
1ab31a8
to
612c73e
Compare
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 11m Commit a6fc9ff046 will soon be integrated into staging-30. Use |
🚨 Branch Integration: This merge request has conflicts We couldn't automatically merge the commit a6fc9ff046 into staging-30! You can use this resolution PR: #2896 to fix the conflicts. If you need support, contact us on Slack #devflow with those details! |
🚂 Branch Integration: starting soon, median merge time is 11m Commit a6fc9ff046 will soon be integrated into staging-30. |
🚂 Branch Integration Commit a6fc9ff046 has been merged into staging-30 in merge commit ab08076032. Check out the triggered pipeline on Gitlab 🦊 |
}, | ||
public entryTypes: string[] = [] | ||
|
||
constructor(public callback: PerformanceObserverCallback) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Quality Violation
Avoid useless constructors (...read more)
This rule is designed to flag constructors that either do nothing or only call the super
function. These constructors are unnecessary and can be safely removed. In JavaScript, if a class extends another class and does not have a constructor, it automatically calls the super
function with all the arguments it receives.
Unnecessary constructors can lead to confusion for other developers who may be reading or maintaining your code. They might spend time trying to figure out why a constructor is there when it doesn't need to be, or they might assume that the constructor is doing something important when it's not. To follow this rule and write good, clean code, you should only write a constructor if it's doing something other than just calling super
.
const child = document.createElement('span') | ||
parentWithoutShadowRoot.appendChild(child) | ||
|
||
const parameters: Array<[string, Node, Node | null]> = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…sts (#3057) * 👷♀️ Remove split Chunk false for webpack * 👷♀️ only remove splitChunk with scope command * Remove splitchunk by default locally * remove `splitChunks` everywhere Somehow, even if we exclude `developer-extension` sources in browser-stack karma configuration, they still end up in the bundle. In those sources, we used a Regexp syntax unsupported in older browsers. This commit work around this issue by using the `new RegExp` constructor instead of the regexp syntax. --------- Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
Caution
Before merging, do not forget to re-enable commented out ci jobs:
Motivation
Changes
Testing
I have gone over the contributing documentation.