Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷‍♀️ [RUM-6424] Change webpack chunk config to speed up local unit tests #3057

Merged
merged 4 commits into from
Nov 5, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/unit/karma.local.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ module.exports = function (config) {
},
webpack: {
...karmaBaseConf.webpack,
optimization: { runtimeChunk: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we only doing it for local unit tests?

Copy link
Contributor Author

@cy-moi cy-moi Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we run multiple times consecutively for cicd with watch option. This only speeds it up when we want to watch changes. BrowserStack unit tests would fail without splitChunk:false.

module: withIstanbulRule(karmaBaseConf.webpack.module),
},
sourceMapLoader: {
Expand Down