-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ [RUM-6929] delay resource collection #3102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
+ Coverage 93.65% 93.70% +0.04%
==========================================
Files 276 279 +3
Lines 7615 7672 +57
Branches 1708 1713 +5
==========================================
+ Hits 7132 7189 +57
Misses 483 483 ☔ View full report in Codecov by Sentry. |
Update shim implementation based on Chrome devs suggestion. It should be more accurate than the previous shim, and also offer `remainingTime` capabilities.
d07a7fb
to
a5bead3
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
a5bead3
to
4bbad82
Compare
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 0s Commit 4bbad82b2d will soon be integrated into staging-44. Use |
Integrated commit sha: 4bbad82 Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit 4bbad82b2d has been merged into staging-44 in merge commit 8ce8f387df. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
We observed that on some condition, processing resources can block the main thread for a significant amount of time.
Changes
This PR mitigate the issue by processing each resource in a "task queue". Tasks are scheduled to be run in "idle tasks" via
requestIdleCallback
. This will break down those big blocking tasks into smaller tasks with lower priority.Testing
I have gone over the contributing documentation.