Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-6801] Collect resource worker processing time #3118

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Nov 7, 2024

Motivation

Resource performent entries have a workerStart property
Worker processing time is defined as workerProcessingTime = entry.fetchStart - entry.workerStart

Changes

Similarly to @resource.connect etc. we could have @resource.worker where:

@resource.worker.start would be workerStart

@resource.worker.duration would be fetchStart - workerStart

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner November 7, 2024 15:48
Copy link

cit-pr-commenter bot commented Nov 7, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.03 KiB 161.08 KiB 56 B +0.03%
Logs 55.76 KiB 55.76 KiB 0 B 0.00%
Rum Slim 109.60 KiB 109.65 KiB 56 B +0.05%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.032 0.041 0.009
addtiming 0.001 0.001 0.000
adderror 0.031 0.039 0.008
startstopsessionreplayrecording 0.880 1.000 0.120
startview 1.003 1.352 0.349
logmessage 0.019 0.022 0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.86 KiB 7.74 KiB -123 B
addaction 38.91 KiB 39.42 KiB 513 B
addtiming 6.82 KiB 7.16 KiB 352 B
adderror 43.74 KiB 44.20 KiB 465 B
startstopsessionreplayrecording 4.66 KiB 4.99 KiB 337 B
startview 425.67 KiB 430.73 KiB 5.06 KiB
logmessage 41.00 KiB 42.47 KiB 1.47 KiB

🔗 RealWorld

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (2016e15) to head (b2f6ace).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
- Coverage   93.61%   93.14%   -0.48%     
==========================================
  Files         276      276              
  Lines        7616     7618       +2     
  Branches     1709     1710       +1     
==========================================
- Hits         7130     7096      -34     
- Misses        486      522      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomanGaignault
Copy link
Contributor Author

/to-staging

@RomanGaignault
Copy link
Contributor Author

/to-staging

@DataDog DataDog deleted a comment from dd-devflow bot Nov 7, 2024
@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2024-11-07 21:05:35 UTC ℹ️ Branch Integration: starting soon, median merge time is 12m

Commit 612fcce538 will soon be integrated into staging-45.


2024-11-07 21:18:03 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 612fcce538 has been merged into staging-45 in merge commit 72d933a823.

Check out the triggered pipeline on Gitlab 🦊

dd-mergequeue bot added a commit that referenced this pull request Nov 7, 2024
Integrated commit sha: 612fcce

Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow dd-devflow bot added the staging-45 label Nov 7, 2024
@RomanGaignault RomanGaignault merged commit 0a018d6 into main Nov 18, 2024
19 checks passed
@RomanGaignault RomanGaignault deleted the romanG/worker-processing-time branch November 18, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants