Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postgres template syntax and parameter output #304

Merged
merged 1 commit into from
May 4, 2016
Merged

Fix postgres template syntax and parameter output #304

merged 1 commit into from
May 4, 2016

Conversation

miketheman
Copy link
Contributor

Closes #302

Signed-off-by: Mike Fiedler miketheman@gmail.com

@miketheman
Fix postgres template syntax and parameter output
12e844c 
- Use correct `.key?` syntax, Fix #300
- Emit correct boolean, introduced in #278
- Add postgres spec test

Closes #302

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman added the bug label May 3, 2016
@miketheman miketheman modified the milestones: Next minor, 2.3.1 May 3, 2016
@miketheman miketheman mentioned this pull request May 3, 2016
Closed
@sethrosenblum
Copy link
Contributor

👍 LGTM

@miketheman miketheman merged commit d6eb9d9 into master May 4, 2016
@miketheman miketheman deleted the miketheman/postgres_fix_n_spec branch May 4, 2016 18:35
@miketheman miketheman modified the milestones: Next Major, 2.3.1, Next minor May 4, 2016
miketheman added a commit that referenced this pull request May 4, 2016
@miketheman
📚 CHANGELOG update [ci skip]
3c568c2 
- #294
- #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@miketheman @sethrosenblum