-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 with integration recipes (was: First stab at recipe-based configuration.) #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned miketheman
Jan 30, 2013
No need to merge yet, but curious about your thoughts. |
|
Using a resource & provider to configure a source to monitor.
… into integration-recipes
Now it's a matter of applying the same logic to the rest of the integrations.
Some thoughts:
Other:
|
ghost
assigned alq666
Apr 23, 2013
These 2 should be used as templates for the rest of the integrations.
activemq, apache, cacti, elasticsearch, haproxy, nginx.
@miketheman what's triggered thus far in Vagrantfile passes a vagrant provision run. I'm going to push and finish the rest on the plane or in Austin. |
Resolved Conflicts: .gitignore README.md attributes/default.rb metadata.rb recipes/dd-agent.rb templates/default/datadog.conf.erb
Picking up any tests that were updated.
Also standardized on server and username for attributes
@alq666 @MisterRayCo Please review the README and CHANGELOG - let me know if something eneds to be updated before I ship this code out to the world. |
@miketheman looking good to me |
miketheman
added a commit
that referenced
this pull request
May 6, 2013
Release 1.0.0 with integration recipes (was: First stab at recipe-based configuration.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cassandra is in.
Role example:
If this is a viable option, the rest of the recipes will follow.