Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] File.exists return true when agent.exe doesn't exist but agent folder exist. #904

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

Pythyu
Copy link
Contributor

@Pythyu Pythyu commented Oct 31, 2023

What does this PR do?

Fix a bug where File.exists return true when agent.exe doesn't exist but agent folder exist. Instead we're using File.file that checks if it's a file and if it exist.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

@Pythyu Pythyu requested a review from a team as a code owner October 31, 2023 15:36
Copy link

@chouquette chouquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits otherwise LGTM!

libraries/recipe_helpers.rb Outdated Show resolved Hide resolved
libraries/recipe_helpers.rb Outdated Show resolved Hide resolved
@Pythyu Pythyu merged commit e8cde55 into main Oct 31, 2023
13 checks passed
@Pythyu Pythyu deleted the pythyu/empty_agent_version branch October 31, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants