-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTEL-941] Upgrade dependency version for github.com/DataDog/agent-payload/v5 #20168
Conversation
db13372
to
1991f5a
Compare
1991f5a
to
96c9da4
Compare
96c9da4
to
b17826b
Compare
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 6f8255b-a841-4973-ad5a-0414a09600de ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
b17826b
to
0993a31
Compare
0993a31
to
cad90c5
Compare
Looks like this was already updated to v5.0.100 in #19912, could probably close this out |
Superseded by #19912 |
What does this PR do?
Upgrade dependency github.com/DataDog/agent-payload/v5 to the latest version.
Motivation
v5.0.99 contains a change that bumps gogo/protobuf to v1.3.2 (DataDog/agent-payload#273). It fixes the known vulnerability for gogo/protobuf versions <1.3.2, and resolves a version conflict with gogo/protobuf in dd-go.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
DataDog/agent-payload#273 re-generates agent_payload and agent_logs_payload pb go files with gogo/protobuf v1.3.2 instead of v1.0.0. While this should be a backwards-compatible change to the generated pb structs and serialization, if we want to be very cautious, we can test with sending any metric / event / sketch / log payloads to the Agent and verify they are properly ingested by backend.
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.