use stdlib maps and slices where possible #22724
Conversation
brycekahle
added
changelog/no-changelog
team/ebpf-platform
qa/done
Go Package Import DifferencesBaseline: a59e0c9
|
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: b6cb202d-36a5-4766-ab79-3ee74489794c Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.67 | [-7.21, +5.87] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | process_agent_standard_check | memory utilization | +0.85 | [+0.81, +0.90] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.82 | [+0.17, +1.47] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.56 | [-0.88, +1.99] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.45 | [+0.40, +0.51] |
| ➖ | file_tree | memory utilization | +0.20 | [+0.10, +0.31] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.14 | [+0.09, +0.20] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.03, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.02, -0.00] |
| ➖ | idle | memory utilization | -0.05 | [-0.09, -0.00] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.28 | [-0.32, -0.23] |
| ➖ | file_to_blackhole | % cpu utilization | -0.67 | [-7.21, +5.87] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
brycekahle
force-pushed
the
bryce.kahle/stdlib-maps-slices
branch
from
796cd56 to
2f7d585
Compare
brycekahle
force-pushed
the
bryce.kahle/stdlib-maps-slices
branch
from
2f7d585 to
5fa2be0
Compare
brycekahle
force-pushed
the
bryce.kahle/stdlib-maps-slices
branch
2 times, most recently
from
76f3d2c to
a395bab
Compare
brycekahle
force-pushed
the
bryce.kahle/stdlib-maps-slices
branch
from
a395bab to
d55bbd0
Compare
Serverless Benchmark Results
tl;dr
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
Benchmark stats |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 7 builds ahead! (estimated merge in less than 2h) Use |
use stdlib maps and slices where possible
What does this PR do?
use stdlib maps and slices where possible
Motivation
parts of
golang.org/x/exp/mapsandgolang.org/x/exp/sliceswere moved into the stdlib in Go 1.21Additional Notes
For some reason
maps.Keyswas not included. See golang/go#61900Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.