Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch install script URL to our CF distribution #28827

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Replace remaining URLs pointing to our S3 bucket to use the CF distribution that is now the public facing entrypoint for the install script.

Motivation

Consistency with our public docs

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouquette chouquette added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Aug 28, 2024
@chouquette chouquette requested review from a team as code owners August 28, 2024 07:17
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 42999719 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42999719 --os-family=ubuntu

Note: This applies to commit 4edb957

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Regression Detector

Regression Detector Results

Run ID: a5a767d5-e81f-4e57-9557-581197fbb8a8 Metrics dashboard Target profiles

Baseline: dccd0de
Comparison: 4edb957

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
basic_py_check % cpu utilization +1.73 [-0.92, +4.38] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.04 [-0.92, +1.01] Logs
file_tree memory utilization +0.03 [-0.04, +0.10] Logs
idle memory utilization +0.01 [-0.02, +0.05] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
otel_to_otel_logs ingress throughput -0.18 [-0.98, +0.63] Logs
pycheck_lots_of_tags % cpu utilization -1.53 [-4.03, +0.98] Logs
tcp_syslog_to_blackhole ingress throughput -2.24 [-14.96, +10.47] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 21m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit f74cad5 into main Aug 28, 2024
341 checks passed
@dd-mergequeue dd-mergequeue bot deleted the chouquette/update_install_script_url branch August 28, 2024 10:16
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants