[CWS] move CWS tag resolver to use the tagger component #28843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Package Import DifferencesBaseline: f74cad5
|
Regression DetectorRegression Detector ResultsRun ID: 080da16c-ee32-46dc-89de-2ac91aa1a853 Metrics dashboard Target profiles Baseline: f74cad5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.69 | [-1.03, +4.41] | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | +0.53 | [-1.99, +3.05] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.10 | [-0.72, +0.91] | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.06 | [-12.92, +13.03] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | idle | memory utilization | -0.10 | [-0.15, -0.05] | Logs |
| ➖ | file_tree | memory utilization | -0.99 | [-1.10, -0.87] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.99 | [-1.96, -0.02] | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ❌ | idle | memory_usage | 9/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes CWS use the tagger resolver component. This tagger is based on the workloadmeta store, so it has no associated cost (contrary to using the remote tagger for example).
Most of the PR is just type piping, changing all module definitions to use the correct component.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes