feat(autodiscovery): support extra_dbname when templating a database instance #31138
+78
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…instance Signed-off-by: wparr-circle <william.parr@circle.com>
rtrieu
approved these changes
Dec 9, 2024
lu-zhengda
approved these changes
Dec 18, 2024
lu-zhengda
added
the
qa/rc-required
wdhif
reviewed
Dec 18, 2024
wdhif
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for templating extra_dbname into a database template for the AWS Aurora auto discovery feature. This will allow users with a non-standard dbname set to automatically discover the primary database named in the Aurora instances.
Fixes #31123
Motivation
Non standardised dbname configuration in our organisations cloud real estate, where we follow neither a practice of using the default
postgresdb nor a standardised alternative such asapp- which is the only hurdle we see in enabling autodiscovery.Describe how to test/QA your changes
Instance template configured with a database name, using the templated extra_dbname variable.
it would be best to test this against an aurora instance configured with a name which is not
postgres, to avoid defaults.Possible Drawbacks / Trade-offs
Additional Notes