Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containerd/cgroups/v3 from 3.0.3 to 3.0.4 #31348

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2024

Bumps github.com/containerd/cgroups/v3 from 3.0.3 to 3.0.4.

Release notes

Sourced from github.com/containerd/cgroups/v3's releases.

v3.0.4

What's Changed

New Contributors

Full Changelog: containerd/cgroups@v3.0.3...v3.0.4

Commits
  • 082af38 Merge pull request #353 from AkihiroSuda/go-mod
  • aa02188 go.mod: bump up
  • 1186f06 CI: drop Go 1.21
  • d98c3a5 Merge pull request #352 from AlbertoBarba/fix/ci-lint
  • 6338d30 fix: use the specified go version in lint jobs
  • ffca7ca Merge pull request #349 from jchorl/jchorl/ignoretimeout
  • 2e25118 Dont ignore failure to create cgroup after timeout
  • 190de3b Merge pull request #346 from thaJeztah/migrate_userns
  • 6f4af8b deprecate RunningInUserNS(), migrate to github.com/moby/sys/userns
  • 0c03de4 Merge pull request #345 from thaJeztah/bump_go
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/containerd/cgroups/v3](https://github.com/containerd/cgroups) from 3.0.3 to 3.0.4.
- [Release notes](https://github.com/containerd/cgroups/releases)
- [Commits](containerd/cgroups@v3.0.3...v3.0.4)

---
updated-dependencies:
- dependency-name: github.com/containerd/cgroups/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Nov 21, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 21, 2024
Copy link

cit-pr-commenter bot commented Nov 21, 2024

Go Package Import Differences

Baseline: e899ec2
Comparison: 16bd939

binaryosarchchange
iot-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns
iot-agentlinuxarm64
+1, -0
+github.com/moby/sys/userns
heroku-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns
cluster-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns
cluster-agentlinuxarm64
+1, -0
+github.com/moby/sys/userns
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/moby/sys/userns
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/moby/sys/userns
heroku-process-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns
serverlesslinuxamd64
+1, -0
+github.com/moby/sys/userns
serverlesslinuxarm64
+1, -0
+github.com/moby/sys/userns
trace-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns
trace-agentlinuxarm64
+1, -0
+github.com/moby/sys/userns
heroku-trace-agentlinuxamd64
+1, -0
+github.com/moby/sys/userns

Copy link

cit-pr-commenter bot commented Nov 21, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0fbe09f9-1491-4a45-acf2-cd9d4fccb1d9

Baseline: b1170d5
Comparison: 77c5679
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization -6.02 [-9.42, -2.63] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.34 [-1.65, +4.33] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.96 [+0.17, +1.76] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.44 [+0.37, +0.50] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.06 [-0.41, +0.54] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.80, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.60] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.69, +0.63] 1 Logs
file_tree memory utilization -0.04 [-0.16, +0.07] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.13 [-0.91, +0.65] 1 Logs
quality_gate_idle memory utilization -0.51 [-0.57, -0.45] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.72 [-1.41, -0.04] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.10 [-1.82, -0.37] 1 Logs
quality_gate_idle_all_features memory utilization -2.29 [-2.42, -2.15] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization -3.65 [-7.51, +0.22] 1 Logs
pycheck_lots_of_tags % cpu utilization -6.02 [-9.42, -2.63] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@L3n41c L3n41c requested review from a team as code owners November 28, 2024 08:38
@L3n41c L3n41c force-pushed the dependabot/go_modules/github.com/containerd/cgroups/v3-3.0.4 branch from 16bd939 to baa0e7d Compare November 28, 2024 08:39
@L3n41c L3n41c removed request for a team November 28, 2024 08:40
@L3n41c L3n41c added the qa/done QA done before merge and regressions are covered by tests label Nov 28, 2024
@L3n41c
Copy link
Member

L3n41c commented Nov 28, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 08:46:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-28 09:34:44 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 22m.

@L3n41c L3n41c added this to the 7.61.0 milestone Nov 28, 2024
@dd-mergequeue dd-mergequeue bot merged commit d2e4580 into main Nov 28, 2024
201 of 202 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/go_modules/github.com/containerd/cgroups/v3-3.0.4 branch November 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant