Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Use containerutils.ContainerID in user and group resolver #31579

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Nov 28, 2024

What does this PR do?

Switch to containerutils.ContainerID type instead of string for user/group resolver.

Motivation

This allows not mixing cgroup and container ids.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@lebauce lebauce requested a review from a team as a code owner November 28, 2024 17:22
@lebauce lebauce added the qa/no-code-change No code change in Agent code requiring validation label Nov 28, 2024
@lebauce lebauce added this to the 7.61.0 milestone Nov 28, 2024
@github-actions github-actions bot added the medium review PR review might take time label Nov 28, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50118448 --os-family=ubuntu

Note: This applies to commit 8723fa0

@lebauce
Copy link
Contributor Author

lebauce commented Nov 28, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 18:05:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-28 18:12:46 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4e405e5f-c24c-48c7-9a91-d4f203812858

Baseline: 57b1ae5
Comparison: 8723fa0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +3.05 [-0.40, +6.50] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.25 [+0.53, +1.98] 1 Logs
quality_gate_idle_all_features memory utilization +1.13 [+1.01, +1.25] 1 Logs bounds checks dashboard
file_tree memory utilization +1.01 [+0.86, +1.17] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.34 [-0.46, +1.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.77, +0.76] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.14, +0.10] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.88, +0.78] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.68, +0.58] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.81, +0.71] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.54, +0.42] 1 Logs
otel_to_otel_logs ingress throughput -0.19 [-0.86, +0.48] 1 Logs
quality_gate_idle memory utilization -0.24 [-0.28, -0.19] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.25 [-0.30, -0.20] 1 Logs
basic_py_check % cpu utilization -0.85 [-4.70, +3.01] 1 Logs
quality_gate_logs % cpu utilization -3.72 [-6.65, -0.78] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 5/10
file_to_blackhole_100ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit b5f2511 into main Nov 28, 2024
253 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lebauce/containerutils-user-group-resolver branch November 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants