-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APR-190] Change the default metric compression kind to be zstd
.
#32087
base: main
Are you sure you want to change the base?
Changes from 11 commits
0b89ebd
40432c6
f231514
782f3e0
6c37b20
24e71d5
ab2f7ea
3f13b2e
735c0a0
99e87c0
2f03f4d
a82e242
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,7 +126,7 @@ func TestPayloadsEmptyServiceCheck(t *testing.T) { | |
|
||
func TestPayloadsServiceChecks(t *testing.T) { | ||
config := mock.New(t) | ||
config.Set("serializer_max_payload_size", 200, pkgconfigmodel.SourceAgentRuntime) | ||
config.Set("serializer_max_payload_size", 250, pkgconfigmodel.SourceAgentRuntime) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The max compress bound for When looking at the actual payload sizes in this test we have: With Zstd: With Zlib: |
||
|
||
serviceCheckCollection := []ServiceChecks{ | ||
{createServiceCheck("1"), createServiceCheck("2"), createServiceCheck("3")}, | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||
# Each section from every release note are combined when the | ||||||
# CHANGELOG.rst is rendered. So the text needs to be worded so that | ||||||
# it does not depend on any information only available in another | ||||||
# section. This may mean repeating some details, but each section | ||||||
# must be readable independently of the other. | ||||||
# | ||||||
# Each section note must be formatted as reStructuredText. | ||||||
--- | ||||||
enhancements: | ||||||
- | | ||||||
Metric payloads are compressed using `zstd` compression by default. | ||||||
This can be reverted to the previous compression kind by adding | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a suggestion. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I see why you've been with kind |
||||||
``serializer_compressor_kind: zlib`` to the configuration. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
auth_token_file_path: /tmp/agent-auth-token | ||
hostname: smp-regression | ||
|
||
dd_url: http://127.0.0.1:9091 | ||
process_config.process_dd_url: http://localhost:9092 | ||
|
||
telemetry.enabled: true | ||
telemetry.checks: '*' | ||
|
||
# Disable cloud detection. This stops the Agent from poking around the | ||
# execution environment & network. This is particularly important if the target | ||
# has network access. | ||
cloud_provider_metadata: [] | ||
|
||
dogstatsd_socket: '/tmp/dsd.socket' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
optimization_goal: ingress_throughput | ||
erratic: false | ||
|
||
target: | ||
name: datadog-agent | ||
command: /bin/entrypoint.sh | ||
cpu_allotment: 8 | ||
memory_allotment: 4GiB | ||
|
||
environment: | ||
DD_API_KEY: 00000001 | ||
DD_HOSTNAME: smp-regression | ||
|
||
profiling_environment: | ||
DD_INTERNAL_PROFILING_BLOCK_PROFILE_RATE: 10000 | ||
DD_INTERNAL_PROFILING_CPU_DURATION: 1m | ||
DD_INTERNAL_PROFILING_DELTA_PROFILES: true | ||
DD_INTERNAL_PROFILING_ENABLED: true | ||
DD_INTERNAL_PROFILING_ENABLE_GOROUTINE_STACKTRACES: true | ||
DD_INTERNAL_PROFILING_MUTEX_PROFILE_FRACTION: 10 | ||
DD_INTERNAL_PROFILING_PERIOD: 1m | ||
DD_INTERNAL_PROFILING_UNIX_SOCKET: /var/run/datadog/apm.socket | ||
DD_PROFILING_EXECUTION_TRACE_ENABLED: true | ||
DD_PROFILING_EXECUTION_TRACE_PERIOD: 1m | ||
DD_PROFILING_WAIT_PROFILE: true | ||
|
||
DD_INTERNAL_PROFILING_EXTRA_TAGS: experiment:uds_dogstatsd_to_api |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
generator: | ||
- unix_datagram: | ||
seed: [2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, | ||
59, 61, 67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131] | ||
path: "/tmp/dsd.socket" | ||
variant: | ||
dogstatsd: | ||
contexts: | ||
inclusive: | ||
min: 10 | ||
max: 100 | ||
name_length: | ||
inclusive: | ||
min: 8 | ||
max: 64 | ||
tag_length: | ||
inclusive: | ||
min: 4 | ||
max: 45 | ||
tags_per_msg: | ||
inclusive: | ||
min: 8 | ||
max: 45 | ||
multivalue_count: | ||
inclusive: | ||
min: 2 | ||
max: 32 | ||
multivalue_pack_probability: 0.08 | ||
kind_weights: | ||
metric: 90 | ||
event: 5 | ||
service_check: 5 | ||
metric_weights: | ||
count: 100 | ||
gauge: 10 | ||
timer: 0 | ||
distribution: 0 | ||
set: 0 | ||
histogram: 0 | ||
bytes_per_second: "1 MiB" | ||
maximum_prebuild_cache_size_bytes: "500 Mb" | ||
|
||
blackhole: | ||
- http: | ||
binding_addr: "127.0.0.1:9091" | ||
response_delay_millis: 75 | ||
- http: | ||
binding_addr: "127.0.0.1:9092" | ||
|
||
target_metrics: | ||
- prometheus: | ||
uri: "http://127.0.0.1:5000/telemetry" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
lading: | ||
version: 0.24.0 | ||
version: 0.25.2 | ||
|
||
target: | ||
cpu_allotment: 8 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to merge with these configuration changes?