-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lading to 0.25.2 #32271
base: main
Are you sure you want to change the base?
Update lading to 0.25.2 #32271
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
[Fast Unit Tests Report] On pipeline 51403577 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 898efd4 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +1.33 | [+0.66, +2.00] | 1 | Logs |
➖ | file_tree | memory utilization | +0.49 | [+0.38, +0.60] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.39 | [-0.41, +1.19] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.12 | [-0.71, +0.94] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.72, +0.83] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.05 | [-0.59, +0.68] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.10, +0.12] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.79, +0.78] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.90, +0.87] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.03 | [-0.49, +0.42] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.04 | [-0.84, +0.76] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.16 | [-0.24, -0.08] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.40 | [-0.45, -0.36] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_logs | % cpu utilization | -0.46 | [-3.65, +2.74] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.03 | [-1.09, -0.97] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.57 | [-2.30, -0.84] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_100ms_latency | lost_bytes | 8/10 | |
❌ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
This release pulls significantly more data from cgroups v2 and also procfs smaps. `total_rss_bytes` is calculated now from `smaps_rollup` and `total_pss_bytes` now exists. See DataDog/lading#1151 for further details. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
06b874c
to
ba773ea
Compare
What does this PR do?
This release pulls significantly more data from cgroups v2 and
also procfs smaps.
total_rss_bytes
is calculated now fromsmaps_rollup
andtotal_pss_bytes
now exists.See DataDog/lading#1151 for further details.