Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lading to 0.25.2 #32271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update lading to 0.25.2 #32271

wants to merge 4 commits into from

Conversation

blt
Copy link
Contributor

@blt blt commented Dec 16, 2024

What does this PR do?

This release pulls significantly more data from cgroups v2 and
also procfs smaps. total_rss_bytes is calculated now from
smaps_rollup and total_pss_bytes now exists.

See DataDog/lading#1151 for further details.

Copy link
Contributor Author

blt commented Dec 16, 2024

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 16, 2024
@blt blt added team/single-machine-performance Single Machine Performance qa/no-code-change No code change in Agent code requiring validation labels Dec 16, 2024 — with Graphite App
@blt blt marked this pull request as ready for review December 16, 2024 22:08
@blt blt requested a review from a team as a code owner December 16, 2024 22:08
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

[Fast Unit Tests Report]

On pipeline 51403577 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

Uncompressed package size comparison

Comparison with ancestor 26052f9b0fdb75103002f7090cab64a7c9a12aa2

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.76MB 1187.76MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1197.00MB 1197.00MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1197.00MB 1197.00MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.77MB 933.77MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 942.98MB 942.98MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.78MB 55.78MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.04MB 505.04MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.30MB 113.30MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.37MB 113.37MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.37MB 113.37MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.77MB 108.77MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.84MB 108.84MB 10.00MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Dec 16, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 070f8502-03cb-4c39-b595-726a64ddfd63

Baseline: 898efd4
Comparison: b72e170
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +1.33 [+0.66, +2.00] 1 Logs
file_tree memory utilization +0.49 [+0.38, +0.60] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.39 [-0.41, +1.19] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.12 [-0.71, +0.94] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.72, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.59, +0.68] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.79, +0.78] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.90, +0.87] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.03 [-0.49, +0.42] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.84, +0.76] 1 Logs
quality_gate_idle_all_features memory utilization -0.16 [-0.24, -0.08] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.40 [-0.45, -0.36] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.46 [-3.65, +2.74] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.03 [-1.09, -0.97] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.57 [-2.30, -0.84] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_100ms_latency lost_bytes 8/10
file_to_blackhole_0ms_latency_http1 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@blt blt changed the title Update lading to 0.25.0 Update lading to 0.25.1 Dec 17, 2024
@blt blt changed the title Update lading to 0.25.1 Update lading to 0.25.2 Dec 18, 2024
blt added 4 commits December 17, 2024 18:50
This release pulls significantly more data from cgroups v2 and
also procfs smaps. `total_rss_bytes` is calculated now from
`smaps_rollup` and `total_pss_bytes` now exists.

See DataDog/lading#1151 for further details.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/update_lading_to_0.25.0 branch from 06b874c to ba773ea Compare December 18, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants