-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Allow specifying cgroup managers for dumps generation #32287
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6d0ce2d Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +2.15 | [+2.07, +2.22] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.90 | [+0.17, +1.63] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.58 | [+0.11, +1.05] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.42 | [-0.25, +1.10] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.23 | [+0.18, +0.27] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.06 | [-0.78, +0.91] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.81, +0.87] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.88, +0.91] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.11] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.66, +0.61] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.11 | [-0.90, +0.67] | 1 | Logs |
➖ | file_tree | memory utilization | -0.12 | [-0.25, +0.02] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.23 | [-1.00, +0.54] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.51 | [-1.28, +0.26] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.85 | [-0.96, -0.73] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_logs | % cpu utilization | -2.05 | [-4.96, +0.86] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
514e56b
to
d2bea12
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51419230 --os-family=ubuntu Note: This applies to commit 68b757a |
go.mod
Outdated
@@ -151,7 +151,7 @@ require ( | |||
github.com/DataDog/datadog-agent/pkg/gohai v0.56.0-rc.3 | |||
github.com/DataDog/datadog-agent/pkg/obfuscate v0.59.0 | |||
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.59.0 | |||
github.com/DataDog/datadog-agent/pkg/security/secl v0.56.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need that ? I think there is a replace anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d3141cb
to
b1a96ef
Compare
b1a96ef
to
68b757a
Compare
/merge |
Devflow running:
|
What does this PR do?
Allow automatically generating activity dumps for systemd services.
Motivation
Currently, generating activity dumps for systemd services is supported but it's a manual step.
This PR allows to:
Describe how you validated your changes
Set
runtime_security_config.activity_dump.cgroup_managers
tosystemd
and check thatactivity dumps are only generated for
systemd
cgroups.Possible Drawbacks / Trade-offs
Additional Notes