Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: DD_APM_OBFUSCATION_CACHE_ENABLED in Agent Main Configuration File #32291

Merged
merged 1 commit into from
Dec 18, 2024
Merged

typo: DD_APM_OBFUSCATION_CACHE_ENABLED in Agent Main Configuration File #32291

merged 1 commit into from
Dec 18, 2024

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Dec 17, 2024 •
edited
Loading

What does this PR do?

Fix typo of DD_APM_OBFUSCATION_CACHE_ENABLED defined in Agent main configuration file.

Motivation

Avoid confusion.

#31336 introduced DD_APM_OBFUSCATION_CACHE_ENABLED.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@keisku keisku added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 17, 2024
@keisku keisku added this to the 7.61.0 milestone Dec 17, 2024
@keisku keisku requested review from a team as code owners December 17, 2024 12:12
@keisku keisku requested a review from misteriaud December 17, 2024 12:12
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 17, 2024
keisku
keisku commented Dec 17, 2024
View reviewed changes
pkg/config/config_template.yaml
@@ -1261,7 +1261,7 @@ api_key:
# obfuscate_sql_values:
# - val1
# cache:
## @param DD_APM_CACHE_ENABLED - boolean - optional
## @param DD_APM_OBFUSCATION_CACHE_ENABLED - boolean - optional
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datadog-agent/pkg/config/setup/apm.go

Line 46 in 435b57c

config.BindEnv("apm_config.obfuscation.cache.enabled", "DD_APM_OBFUSCATION_CACHE_ENABLED")

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 17, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51313766 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 4189bbbf669b8eb0fe987e02ebcbb4507b001c3b

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB ⚠️ 1196.98MB 1196.98MB 140.00MB
datadog-agent-x86_64-suse 0.00MB ⚠️ 1196.98MB 1196.98MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 942.98MB 942.98MB 140.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ⚠️ 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ⚠️ 78.65MB 78.65MB 10.00MB
datadog-agent-amd64-deb 0.00MB ✅ 1187.74MB 1187.74MB 140.00MB
datadog-agent-arm64-deb 0.00MB ✅ 933.76MB 933.76MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 55.78MB 55.78MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 505.05MB 505.05MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 108.84MB 108.84MB 10.00MB

Decision

⚠️ Warning

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fbdd9a9a-40ab-4aa2-893f-f8a867a75731

Baseline: 4189bbb
Comparison: b4c7a75
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +0.49 [-2.40, +3.39] 1 Logs
➖ file_tree memory utilization +0.35 [+0.21, +0.50] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.27 [-0.49, +1.03] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.81, +0.95] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.06 [-0.57, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.81, +0.87] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.68, +0.72] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.90, +0.92] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.11] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.03 [-0.17, +0.11] 1 Logs bounds checks dashboard
➖ file_to_blackhole_500ms_latency egress throughput -0.09 [-0.85, +0.67] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.20 [-0.66, +0.27] 1 Logs
➖ otel_to_otel_logs ingress throughput -0.21 [-0.85, +0.43] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.22 [-0.29, -0.14] 1 Logs
➖ quality_gate_idle memory utilization -0.73 [-0.78, -0.69] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.81 [-1.53, -0.08] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ file_to_blackhole_300ms_latency lost_bytes 9/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dustmop
Copy link
Contributor

dustmop commented Dec 17, 2024

Just a heads up that we have another PR that is cleaning up the config, but it looks like they should merge cleanly.

@misteriaud misteriaud removed their request for review December 17, 2024 21:58
@keisku
Copy link
Contributor Author

keisku commented Dec 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-18 00:29:51 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

2024-12-18 00:53:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 26052f9 into main Dec 18, 2024
212 of 214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the keisku/typo-obfuscation-cache branch December 18, 2024 00:53
@github-actions github-actions bot modified the milestones: 7.61.0, 7.62.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgimalac pgimalac pgimalac approved these changes

@jhgilbert jhgilbert jhgilbert approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
4 participants
@keisku @dustmop @jhgilbert @pgimalac