Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard warning logs from client-go when using ComponentStatus on K8S >= 1.19 #7946

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Discard warning logs from client-go when using ComponentStatus on K8S >= 1.19 #7946

merged 1 commit into from
Apr 22, 2021

Conversation

vboulineau
Copy link
Contributor

@vboulineau vboulineau commented Apr 21, 2021 •
edited
Loading

What does this PR do?

ComponentStatus is currently in Cluster Agent apiserver check. Using custom warning logger to discard spammy log in client-go.

See kubernetes/kubernetes#93570

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Run Cluster Agent on K8S >= 1.19, you should not see any log with v1 ComponentStatus is deprecated in v1.19+

@vboulineau vboulineau added this to the DCA_1.12.0 milestone Apr 21, 2021
@vboulineau vboulineau requested a review from a team April 21, 2021 16:04
@vboulineau vboulineau requested a review from a team as a code owner April 21, 2021 16:04
clamoriniere
clamoriniere reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@clamoriniere clamoriniere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better understand: is the ComponentStatus deprecated but stil present in the api-server (only deprecation notice)?

@vboulineau
Copy link
Contributor Author

To better understand: is the ComponentStatus deprecated but stil present in the api-server (only deprecation notice)?

Yes, ComponentStatus is currently deprecated but, ATM, removal is not planned yet.

@vboulineau vboulineau merged commit 089d573 into master Apr 22, 2021
@vboulineau vboulineau deleted the vboulineau/discard-warn branch April 22, 2021 08:37
@kaitlavs kaitlavs mentioned this pull request Apr 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog component/cluster-agent kind/bug team/containers
Projects
None yet
Milestone
DCA_1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vboulineau @clamoriniere