Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support .NET runtimes #236

Merged
merged 13 commits into from
Dec 5, 2023
Merged

feat: support .NET runtimes #236

merged 13 commits into from
Dec 5, 2023

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Dec 4, 2023 •
edited
Loading

What does this PR do?

Allows .NET AWS Lambdas to be instrumented using this CDK construct.

Motivation

We allow this in other Datadog instrumentation tools.

Testing Guidelines

Tested manually, added an example for both the typescript and python stacks under examples.
Also added a unit test for the wrapper.

Additional Notes

I also removed some outdated runtimes from our unit tests.
Didn't create integration tests yet.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista requested a review from a team as a code owner December 4, 2023 21:18
@duncanista duncanista requested a review from a team as a code owner December 4, 2023 21:28
@duncanista
Merge branch 'main' of ssh://github.com/DataDog/datadog-cdk-construct…
00ebc07 
…s into jordan.gonzalez/support-dotnet-runtimes
alexgallotta
alexgallotta reviewed Dec 4, 2023
View reviewed changes
Copy link

@alexgallotta alexgallotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But left a few comments (especially the one of undefined vs null)
It would be great to remove deduplicate code where it doesn't affect readibility, especially in tests

v2/src/layer.ts Show resolved Hide resolved
v2/src/redirect.ts Show resolved Hide resolved
v2/src/redirect.ts Outdated Show resolved Hide resolved
v2/test/env.spec.ts Show resolved Hide resolved
joeyzhao2018
joeyzhao2018 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanista duncanista merged commit 62c45a9 into main Dec 5, 2023
12 checks passed
@duncanista duncanista deleted the jordan.gonzalez/support-dotnet-runtimes branch December 5, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgallotta alexgallotta alexgallotta left review comments

@astuyve astuyve astuyve left review comments

@alai97 alai97 alai97 approved these changes

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@duncanista @astuyve @joeyzhao2018 @alexgallotta @alai97