feat: Enabling go 1.12 in CI

DataDog · Jun 21, 2022 · 38c41cc · 38c41cc
1 parent adf7e06
commit 38c41cc
Show file tree

Hide file tree

Showing 24 changed files with 85 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -49,6 +49,7 @@ commands:
       - run: go vet ./statsd/...
       - run: go fmt ./statsd/...
       - run: go test -v ./statsd/...
+      - run: go run -v ./example
 
 jobs:
   # Those allow us to have the os name in the job name. 'matrix' don't add static parameters to the name in the circleci
@@ -72,4 +73,11 @@ workflows:
       - tests_arm64:
           matrix:
             parameters:
-              go-version: ["1.13", "1.14", "1.15", "1.16", "1.17", "1.18"]
+              go-version:
+                - "1.12"
+                - "1.13"
+                - "1.14"
+                - "1.15"
+                - "1.16"
+                - "1.17"
+                - "1.18"
diff --git a/.github/workflows/datadog-go.yaml b/.github/workflows/datadog-go.yaml
@@ -8,8 +8,18 @@ jobs:
   native:
     strategy:
       matrix:
-        go-version: [ 1.18, 1.17, 1.16, 1.15, 1.14, 1.13]
-        runs-on: [ ubuntu-latest, windows-latest, macos-latest ]
+        go-version:
+          - 1.18
+          - 1.17
+          - 1.16
+          - 1.15
+          - 1.14
+          - 1.13
+          - 1.12
+        runs-on:
+          - ubuntu-latest
+          - windows-latest
+          - macos-latest
       fail-fast: false
     runs-on: ${{ matrix.runs-on }}
     steps:
@@ -22,3 +32,4 @@ jobs:
       - run: go vet ./statsd/...
       - run: go fmt ./statsd/...
       - run: go test -race -v ./statsd/...
+      - run: go run -v ./example
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/DataDog/datadog-go/v5
 
-go 1.13
+go 1.12
 
 require (
 	github.com/Microsoft/go-winio v0.5.0

diff --git a/statsd/aggregator_test.go b/statsd/aggregator_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/buffer_pool_test.go b/statsd/buffer_pool_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/buffer_test.go b/statsd/buffer_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/container_test.go b/statsd/container_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/end_to_end_udp_test.go b/statsd/end_to_end_udp_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/end_to_end_uds_test.go b/statsd/end_to_end_uds_test.go
@@ -1,4 +1,5 @@
-// +build !windows
+//go:build go1.13
+// +build go1.13
 
 package statsd
 

diff --git a/statsd/event_test.go b/statsd/event_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/format_benchmark_test.go b/statsd/format_benchmark_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/format_test.go b/statsd/format_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/metrics_test.go b/statsd/metrics_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/noop_test.go b/statsd/noop_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/options_test.go b/statsd/options_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/pipe_windows_test.go b/statsd/pipe_windows_test.go
@@ -1,4 +1,5 @@
-// +build windows
+//go:build windows && go1.13
+// +build windows,go1.13
 
 package statsd
 
@@ -21,7 +22,7 @@ func createNamedPipe(t *testing.T) (string, *os.File, net.Listener) {
 	pipepath := WindowsPipeAddressPrefix + f.Name()
 	ln, err := winio.ListenPipe(pipepath, &winio.PipeConfig{
 		SecurityDescriptor: "D:AI(A;;GA;;;WD)",
-		InputBufferSize:    1_000_000,
+		InputBufferSize:    1000000,
 	})
 	if err != nil {
 		os.Remove(f.Name())

diff --git a/statsd/sender_test.go b/statsd/sender_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/service_check_test.go b/statsd/service_check_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/statsd_benchmark_test.go b/statsd/statsd_benchmark_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd_test
 
 import (

diff --git a/statsd/statsd_test.go b/statsd/statsd_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/telemetry_test.go b/statsd/telemetry_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/test_helpers_test.go b/statsd/test_helpers_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (

diff --git a/statsd/uds_test.go b/statsd/uds_test.go
@@ -1,4 +1,5 @@
-// +build !windows
+//go:build !windows && go1.13
+// +build !windows,go1.13
 
 package statsd
 

diff --git a/statsd/worker_test.go b/statsd/worker_test.go
@@ -1,3 +1,6 @@
+//go:build go1.13
+// +build go1.13
+
 package statsd
 
 import (
@@ -9,7 +12,7 @@ import (
 
 func TestShouldSample(t *testing.T) {
 	rates := []float64{0.01, 0.05, 0.1, 0.25, 0.5, 0.75, 0.9, 0.99, 1.0}
-	iterations := 50_000
+	iterations := 50000
 
 	for _, rate := range rates {
 		rate := rate // Capture range variable.