Use multiple UDP sockets for sending statsd packets. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use multiple UDP sockets for sending statsd packets.
Currently the datadog-go statsd client uses a single UDP socket to send packets to the statsd server. On nodes with a larger number of cores (64+) this creates a bottleneck for sending packets. The Veneur statsd proxy can receive packets on multiple sockets, but since datadog-go only sends packets via a single socket, veneur will only receive packets on a single socket. The single socket becomes a bottleneck within the Linux kernel, and the maximum packet rate is determined by rate that a single core can send packets. This PR provides datadog-go the capability to send packets over multiple sockets and increase the maximum packet rate that the datadog-go client can emit