Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): Add Container App filters to Azure Resource Manager template #699

Merged
merged 11 commits into from
Oct 25, 2023

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented Oct 10, 2023

What does this PR do?

Adds Container App filters to the deploy to azure ARM templates.

Testing Guidelines

Tested the Subscription Level template with @ashwingandhi-ddog in person, and tested the management group level templates:

image

And verified that they ended up correctly in datadog.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ava-silver ava-silver changed the title [AZI-1884] Add Container App filters [AZI-1884] Add Container App filters to Azure Resource Manager Bicep template Oct 10, 2023
@ava-silver ava-silver marked this pull request as ready for review October 12, 2023 00:15
@ava-silver ava-silver requested a review from a team as a code owner October 12, 2023 00:15
@ashwingandhi-ddog ashwingandhi-ddog self-requested a review October 16, 2023 18:25
@ava-silver ava-silver changed the title [AZI-1884] Add Container App filters to Azure Resource Manager Bicep template feat(azure): Add Container App filters to Azure Resource Manager Bicep template Oct 25, 2023
@ava-silver ava-silver changed the title feat(azure): Add Container App filters to Azure Resource Manager Bicep template feat(azure): Add Container App filters to Azure Resource Manager template Oct 25, 2023
@ava-silver ava-silver merged commit 02cf717 into master Oct 25, 2023
11 checks passed
@ava-silver ava-silver deleted the ava.silver/azi-1884/add-container-app-filters branch October 25, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants