Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable step function tracing at forwarder level #831
Enable step function tracing at forwarder level #831
Changes from all commits
eddcf5d
10902be
b2fe35e
cff1a0e
3806fc5
f330f88
2f0555c
994d0b5
9e13267
cbcef0c
db81dc0
3c62195
2e7ff49
dbd763b
587c198
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will be the default value in CloudFormation console (shown as below) when customer install a new DD forwarder?
It should be default false, but customers can set it to be true if they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The console will use the default value in
Parameters:
section, so in this case it would befalse
.https://github.com/DataDog/datadog-serverless-functions/pull/831/files#diff-7c5bda646bf6435d9285913888d0473f0ac98ed0fdd025ae5d9ea357ad9b3ffaR164-R166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the default behavior, here is the flow
DdStepFunctionTraceEnabled
to befalse
SetDdStepFunctionTraceEnabled
condition will then befalse
becauseDdStepFunctionTraceEnabled != true
DD_STEP_FUNCTION_TRACE_ENABLED
will beAWS::NoValue
, which means the env var won't be set