add constants for error codes

crates/bins/src/bin/datadog_static_analyzer_server/cli.rs

@@ -11,6 +11,10 @@ use tracing_appender::non_blocking::WorkerGuard;
 use tracing_appender::rolling::RollingFileAppender;
 use tracing_subscriber::EnvFilter;
 
+use crate::datadog_static_analyzer_server::error_codes::{
+    ERROR_CHANNEL_DISCONNECTED, ERROR_SHUTDOWN_FAILURE,
+};
+
 use super::state::ServerState;
 use super::utils::get_current_timestamp_ms;
 
@@ -237,7 +241,7 @@ pub fn prepare_rocket(tx_keep_alive_error: Sender<i32>) -> Result<RocketPreparat
                                 "No graceful exit on first attempt. Trying another channel"
                             );
                             // signal the main thread to kill itself. wait for 10 secs and use abort if needed.
-                            let _ = tx_keep_alive_error.send(101).await;
+                            let _ = tx_keep_alive_error.send(ERROR_SHUTDOWN_FAILURE).await;
                             thread::sleep(Duration::from_secs(10));
                             tracing::error!(
                                 "No graceful exit on suicide channel.  Aborting the process"
@@ -249,7 +253,7 @@ pub fn prepare_rocket(tx_keep_alive_error: Sender<i32>) -> Result<RocketPreparat
                 } else {
                     tracing::error!("CRITICAL: The channel has disconnected");
                     // if the channel dies we're going to exit the process with a custom error code.
-                    let _ = tx_keep_alive_error.send(100).await;
+                    let _ = tx_keep_alive_error.send(ERROR_CHANNEL_DISCONNECTED).await;
                 };
             });
         }

crates/bins/src/bin/datadog_static_analyzer_server/mod.rs

@@ -2,10 +2,14 @@ use std::process;
 
 use cli::{CliError, RocketPreparation};
 use endpoints::EndpointError;
+use error_codes::{
+    ERROR_BAD_ADDRESS, ERROR_CHANNEL_SENDER_DROPPED, ERROR_GENERAL, ERROR_INVALID_ARGUMENT,
+};
 use rocket::tokio::sync::mpsc::channel;
 
 mod cli;
 mod endpoints;
+mod error_codes;
 mod fairings;
 mod ide;
 mod state;
@@ -31,8 +35,8 @@ pub async fn start() {
         Err(e) => {
             eprintln!("Error found: {e}");
             match e {
-                CliError::Parsing(_) => process::exit(22), // invalid argument code
-                _ => process::exit(1),                     // generic error code
+                CliError::Parsing(_) => process::exit(ERROR_INVALID_ARGUMENT),
+                _ => process::exit(ERROR_GENERAL),
             }
         }
         Ok(RocketPreparation::NoServerInteraction) => {
@@ -53,13 +57,12 @@ pub async fn start() {
                 *rocket = rocket.attach(fairings::KeepAlive);
             }
 
-            // launch the rocket
-
+            // launch the rocket and check if we receive a keep-alive error
             let result = rocket::tokio::select! {
                 a = endpoints::launch_rocket_with_endpoints(*rocket, tx_rocket_shutdown) => a,
                 b = rx_keep_alive_error.recv() => match b {
                     Some(c) => Err(c.into()),
-                    _ => Err(EndpointError::ExitCode(102))
+                    _ => Err(EndpointError::ExitCode(ERROR_CHANNEL_SENDER_DROPPED))
                 },
             };
 
@@ -76,7 +79,7 @@ pub async fn start() {
                     EndpointError::ExitCode(code) => process::exit(code),
                     EndpointError::RocketError(re) => {
                         if let rocket::error::ErrorKind::Bind(_) = re.kind() {
-                            process::exit(14); // bad address error code
+                            process::exit(ERROR_BAD_ADDRESS);
                         }
                     }
                     _ => (),