chore(integration-tests): require minimum results to be at least 2 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
As mentioned earlier, rules are subject to constant updates and changes to mitigate false positives or improve performance. Our current integration scripts check for an exact number of violations to be flagged, which is really brittle, as changing one rule can change this number easily if the change is mitigating false positives.
What is your solution?
We should only check that a bare minimum number of results are detected. For example, if we're detecting around ~20, we can safely assume that we will always have at least 2 results. This logic was implemented in #505 with the addition of new integration tests, but we should also update the existing ones to follow this logic.
Alternatives considered
What the reviewer should know
The integration scripts for python, docker, and js-ts were all updated to check for a bare minimum of 2 violations, instead of the exact number of violations detected at the time the script was created.