[STAL-2781] Build release Linux binary on Ubuntu 20.04 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonforal
requested review from
jacobotb and
juli1
and removed request for
jacobotb
|
Special thanks to @robertohuertasm for debugging this and identifying the solution |
|
Thank you @jasonforal for your nice words ❤️ and for your thorough work on this issue 🙌🏻 . It's always a pleasure to collaborate with you! |
juli1
reviewed
Oct 1, 2024
| chmod go+r /etc/apt/keyrings/githubcli-archive-keyring.gpg | ||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null | ||
| apt-get update | ||
| apt-get install gh -y |
There was a problem hiding this comment.
The gh CLI is needed to upload the artifact. A vanilla Ubuntu image doesn't come with this pre-installed
juli1
reviewed
Oct 1, 2024
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null | ||
| apt-get update | ||
| apt-get install gh -y | ||
| git config --global --add safe.directory $GITHUB_WORKSPACE |
There was a problem hiding this comment.
Same story -- Github's runners automatically have this configured, but that doesn't apply to a vanilla Ubuntu image. Without this, the job fails because of git throwing an unsafe repository error
juli1
reviewed
Oct 1, 2024
|
Yes, for the APIs we're using, newer versions of glibc have backwards-compatibility. So it works on 22.04, 24.04, etc. |
juli1
approved these changes
Oct 1, 2024
jasonforal
force-pushed
the
jf/STAL-2781
branch
from
505d2e5 to
2a3a947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
We currently compile our Linux release binaries on GitHub's
ubuntu-latestrunner, which resolves to ubuntu 24.04. Because 24.04 uses a newer version of glibc, it compiles binaries that expect more recent versions of glibc (currently, v8 expectspthread_getattr_np@GLIBC_2.32). This leads to an error when trying to run the binary on older versions of Linux (specifically Ubuntu 20.04, which ships with glibc 2.31)What is your solution?
Building on Ubuntu 20.04 generates a binary that now expects glibc 2.2.5:
❯ greadelf -a datadog-static-analyzer-server | grep pthread_getattr_np 000003efe688 011700000006 R_X86_64_GLOB_DAT 0000000000000000 pthread_getattr_np@GLIBC_2.2.5 + 0And thus the binaries now work on Ubuntu 20.04.
You can confirm that this modification to the release workflow functions correctly by looking at a pre-release that I just generated to test it:
We need to add an extra step to set up the container, as the base image is missing the packages that GitHub installs by default on a non-containerized runner (curl, gh, etc).
Alternatives considered
What the reviewer should know
ubuntu-latest(currently 24.04). Assuming glibc doesn't have forward-compatibility issues, this setup is fine.