Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STAL-3002] Only use latest tag on ghcr for stable releases #524

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jasonforal
Copy link
Collaborator

What problem are you trying to solve?

Currently, when a pre-release is published, it is marked with the latest tag on GHCR:

image
image

Pre-release is intended for us to be able to test an image internally before publishing, so this behavior is unexpected.

What is your solution?

  • Only assign the latest tag when the release is not a pre-release.
  • Additionally, add a commit SHA tag to the image.
image
image

Alternatives considered

What the reviewer should know

  • The git tag is still used as one of the docker image tags, so our current method of tagging with a number like 0.3.5 will continue to function the same.

@jasonforal jasonforal requested a review from juli1 October 7, 2024 22:45
@jasonforal jasonforal requested a review from a team as a code owner October 7, 2024 22:45
@jasonforal jasonforal merged commit 5565af2 into main Oct 8, 2024
121 checks passed
@jasonforal jasonforal deleted the jf/STAL-3002 branch October 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants