Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): allow to compile in a windows machine #542

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

robertohuertasm
Copy link
Member

@robertohuertasm robertohuertasm commented Oct 30, 2024

What problem are you trying to solve?

While trying to compile the project in my Windows 11 machine I found out I was unable to compile the project due to some issues:

  1. use of unix commands in build.rs
  2. walkdir dependency mismatch

What is your solution?

  1. I replaced the UNIX commands for Rust commands.
  2. Updated Walkdir to 2.5.0, which is the latest version. For some reason, the version we had in Cargo.toml (2.3.3) didn't have the follow_root_links method that we're using in file_utils.rs. Not sure how, in Mac we're getting the right version (maybe through another dependency), but this is not true in Windows, so I decided to update the dependency.

Alternatives considered

What the reviewer should know

Tested this in a Windows 11 machine and it works.

RE #541

@robertohuertasm robertohuertasm requested a review from a team as a code owner October 30, 2024 20:02
@jasonforal
Copy link
Collaborator

Nice, thanks for this!

@robertohuertasm robertohuertasm merged commit 2e96cc1 into main Oct 31, 2024
70 checks passed
@robertohuertasm robertohuertasm deleted the rob/fix/windows-compilation branch October 31, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants