Minor fix for the User Resource and correction in find_attr #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mfa_enabled
. This attribute is currently not documented as requested by the @DataDog/team-aaa-identity team, related PR.find_attr
would not check if the variabler_obj
is not None before performing operations on it, causing failures.Description of the Change
For issue 1, I added the attribute
mfa_enabled
to be excluded so that it is ignored. For issue 2, we check thatr_obj
is not None before trying any operations.Alternate Designs
Possible Drawbacks
Verification Process
I ran manual and automated tests to make sure that the issues don't happen again.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.