Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global mute flag support #212

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Feb 5, 2024

Add a flag to create global downtime schedule during sync to avoid false positives.

Supercedes: #205

@skarimo skarimo requested a review from a team as a code owner February 5, 2024 20:19
Copy link

@heyronhay heyronhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some phrasing suggestions, but looks good otherwise!

README.md Outdated Show resolved Hide resolved
datadog_sync/commands/sync.py Outdated Show resolved Hide resolved
datadog_sync/utils/resource_utils.py Outdated Show resolved Hide resolved
@skarimo skarimo merged commit 3c6ba79 into sherz/global-tagging-support Feb 12, 2024
2 checks passed
@skarimo skarimo deleted the sherz/global-downtime branch February 12, 2024 23:15
skarimo added a commit that referenced this pull request Feb 12, 2024
* add support for tag injection

* add tests for tagging_config

* re-record cassettes

* Add global mute flag support (#212)

* place global downtime creation behind a flag

* update readme

* apply code review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants