Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APITL-862] Add support for moving index to end of order list during deletion #233

Merged
merged 8 commits into from
May 3, 2024

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Apr 23, 2024

No description provided.

@skarimo skarimo requested a review from a team as a code owner April 23, 2024 19:41
luchenyuxx
luchenyuxx previously approved these changes Apr 26, 2024
@luchenyuxx luchenyuxx changed the title Add support for moving index to end of order list during deletion [APITL-856] Add support for moving index to end of order list during deletion Apr 26, 2024
@luchenyuxx luchenyuxx changed the title [APITL-856] Add support for moving index to end of order list during deletion [APITL-862] Add support for moving index to end of order list during deletion Apr 26, 2024
Copy link

@luchenyuxx luchenyuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add an unit test for this?

@skarimo skarimo requested a review from luchenyuxx April 29, 2024 16:45
luchenyuxx
luchenyuxx previously approved these changes Apr 30, 2024
@skarimo skarimo merged commit aa57eba into main May 3, 2024
9 checks passed
@skarimo skarimo deleted the sherz/logs-index-delete branch May 3, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants