HAMR-179 Add pyproject.toml to fix docker build #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichards-87
previously approved these changes
Sep 4, 2024
heyronhay
previously approved these changes
Sep 5, 2024
michael-richey
changed the title
skarimo
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
docker buildcommand which is currently broken.Description of the Change
Creates a skeleton
pyproject.tomlfile so the build will work.Alternate Designs
We could use a different build backend. For example, passing
--use-pep517would fix it but swapping the build backend seems like a larger change. Changing the base image (to python3.12-slim-bullseye) also seems to resolve but again it's a larger change.Verification Process
Tested the documented
docker buildcommand then ran animportandsyncwith the newly created docker image.