This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
config: support overriding agent endpoint via env #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
All good to me. @LotharSee maybe you want to check this change too just to be aware of it?
LotharSee
reviewed
Mar 27, 2018
config/merge_env.go
Outdated
| @@ -26,6 +26,10 @@ func mergeEnv(c *AgentConfig) { | |||
| c.HostName = v | |||
| } | |||
|
|
|||
| if v := os.Getenv("DD_TRACE_AGENT_ENDPOINT"); v != "" { | |||
There was a problem hiding this comment.
To kind of align it with its config option apm_config.apm_dd_url, good let's move to DD_APM_DD_URL. I'm not in love with that but that's the closest we will get.
LeoCavaille
force-pushed
the
leo/supportenv
branch
from
15132f2
to
aa67dd0
Compare
LotharSee
approved these changes
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal use.