Fix dd-agent CLI on Linux #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/usr/bin/dd-agent command haven't worked anymore since... a big while. I suspect that this is due to a slight variation in the behaviour of the `extra_package_file` between Omnibus 3 and Omnibus 4 but didn't really have time to dig more into it. This fix just moves the creation of this file to the `postinst` script which fixes the issue in a rather simple way. This same file also get deleted in the `postrm` script so that the `dd-agent` commands simply don't exist anymore after removing the agent.
elafarge
force-pushed
the
etienne/fix-ddagent-and-consors-cli
branch
from
f6ca883
to
9b9bdcf
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/usr/bin{dd-agent,dogstatsd,dd-forwarder}commands haven't workedanymore since... a big while. I suspect that this is due to a slight
variation in the behaviour of the
extra_package_filebetween Omnibus 3and Omnibus 4 but I didn't really have time to dig more into it.
This fix just moves the creation of these files to the
postinstscriptwhich fixes the issue in a rather simple way. These same files also get
deleted in the
postrmscript so that these commands simply don't existanymore after removing the agent.