Skip to content

Commit

Permalink
Add make lint
Browse files Browse the repository at this point in the history
  • Loading branch information
alq666 committed Aug 14, 2013
1 parent 513b7c7 commit bffe54c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion dogstatsd.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def init(config_path=None, use_watchdog=False, use_forwarder=False):

target = c['dd_url']
if use_forwarder:
target = c['dogstatsd_target']
target = c['dogstatsd_target']

hostname = get_hostname(c)

Expand Down
3 changes: 3 additions & 0 deletions packaging/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,6 @@ tmp:
cp ../dist/*.rpm /tmp/shared || true
all: clean deb rpm
lint:

This comment has been minimized.

Copy link
@clutchski

clutchski Aug 14, 2013

Contributor

Nice. This is great. Should we consolidate into one makefile? we have one here and one Rakefile.

This comment has been minimized.

Copy link
@elijahandrews

elijahandrews Aug 14, 2013

Contributor

It looks like the rakefile is more for development tasks (running tests) while the makefile is for release tasks (building packages). I think that it makes sense to keep them separate, since everybody will have use for the rake tasks but only the individual running a release will want to use the make tasks.

Might be worth adding a lint task to the Rakefile too, though. If we do, we should also add pylint to requirements.txt

This comment has been minimized.

Copy link
@alq666

alq666 Aug 14, 2013

Author Member

Moved it to Rakefile, makes more sense.

find .. -name \*.py -type f -not -path \*tests\* -exec pylint --rcfile=../.pylintrc --reports=n --output-format=parseable {} \;

0 comments on commit bffe54c

Please sign in to comment.