Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect conversion of system.io.bytes_per_s metric #1718

Closed
domoench opened this issue Jun 22, 2015 · 1 comment
Closed

Incorrect conversion of system.io.bytes_per_s metric #1718

domoench opened this issue Jun 22, 2015 · 1 comment

Comments

@domoench
Copy link

Incorrect conversion between megabytes and bytes HERE.

Also in the test file: tests/checks/mock/test_sysstat.py

'system.io.bytes_per_s': mb_s * 10**6

Should be

'system.io.bytes_per_s': mb_s * 2**20

I'm assuming here that we always mean Mebibytes when we say Megabytes. When metrics metadata is fully implemented the plan is to completely shift to the unambiguous kibi, mebi, gibi byte prefixes and no longer refer to the ambiguous kilo, mega, giga scientific prefixes for byte units.

@remh
Copy link
Contributor

remh commented Sep 14, 2015

Thanks for the feedback @domoench fixed in #1912

urosgruber pushed a commit to urosgruber/dd-agent that referenced this issue Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants